Add performance tests for localized site #5624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixarntz
reviewed
Nov 6, 2023
There was a problem hiding this comment.
Thanks @swissspidy, I like where this is going. A bit of feedback (mostly questions) below.
swissspidy
requested review from
felixarntz,
Mamaduka,
desrosj,
joemcgill and
mukeshpanchal27
joemcgill
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Thanks @swissspidy for the PR. Overall look solid to me left some nit-pick.
felixarntz
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
@swissspidy Thanks for the updates, LGTM!
Are these values just going to appear in the codevitals dashboard, or do we have to update that project as well?
|
I will ping Riad to update the dashboard once committed |
mukeshpanchal27
approved these changes
Nov 8, 2023
Co-authored-by: Mukesh Panchal <[email protected]>
|
Committed in https://core.trac.wordpress.org/changeset/57083 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
de_DElanguage pack to ensure test site can be localizedde_DEactivelog-results.jsto ensure all new tests are sent to the Code Vitals dashboard tooExample output on CI:
Trac ticket: https://core.trac.wordpress.org/ticket/59815
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.