Change wp_pattern_category public param to false #5604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the REST API fixtures need to be regenerated. Running the unit test WP_Test_REST_Schema_Initialization should do it I think.
|
|
Hmm, the CI jobs are failing. Pulling it down locally to have a peek. |
hellofromtonya
approved these changes
Nov 1, 2023
|
Committed via https://core.trac.wordpress.org/changeset/57044 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Sets the pattern categories taxonomy
publicparam tofalseinstead of trueWhy?
It was suggested here that this would be a better setting for this taxonomy as it only needs to be accessed in admin, not the frontend.
Trac ticket: https://core.trac.wordpress.org/ticket/59569
Testing Instructions
Log in as Admin, Editor, and Author users and make sure that each of these can add new and existing categories to patterns in the post editor and the site editor patterns library.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.