Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed schema for global styles REST API endpoint wp/v2/global-styles/{id} #7234

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

narenin
Copy link

@narenin narenin commented Aug 23, 2024

Trac ticket: https://core.trac.wordpress.org/ticket/61911


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Aug 23, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props narenin, johnbillion, timothyblynjacobs.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@johnbillion
Copy link
Member

@narenin Thanks for the PR. int isn't a valid type in JSON schema.

@narenin
Copy link
Author

narenin commented Aug 25, 2024

@johnbillion Thanks for the review, I have updated the same to integer, please check.

@TimothyBJacobs
Copy link
Member

TimothyBJacobs commented Sep 17, 2024

This is slightly weird because the value does have a sanitize_callback registered for it which calls urldecode, which seems like an indication that the value is supposed to be a string. Are we sure this is supposed to be an integer? If so, we should probably also be removing the sanitize_callback.


We'd probably also want to update the regex to use \d+ instead of \w-


Sneaky edit 2, yeah it's definitely expecting a post id. So yeah I think this conceptually makes sense, we just need to make a few more changes.

@narenin
Copy link
Author

narenin commented Sep 18, 2024

Thanks @johnbillion @TimothyBJacobs for your feedback's, I have implemented the same, could you please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants