-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed schema for global styles REST API endpoint wp/v2/global-styles/{id}
#7234
base: trunk
Are you sure you want to change the base?
Fixed schema for global styles REST API endpoint wp/v2/global-styles/{id}
#7234
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
@narenin Thanks for the PR. |
@johnbillion Thanks for the review, I have updated the same to |
This is slightly weird because the value does have a We'd probably also want to update the regex to use Sneaky edit 2, yeah it's definitely expecting a post id. So yeah I think this conceptually makes sense, we just need to make a few more changes. |
Thanks @johnbillion @TimothyBJacobs for your feedback's, I have implemented the same, could you please take a look. |
Trac ticket: https://core.trac.wordpress.org/ticket/61911
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.