Improve assertion accuracy for what is being tested.

WordPress · Jun 9, 2024 · dfcf36d · dfcf36d
1 parent 7534c53
commit dfcf36d
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/tests/phpunit/tests/admin/includes/wpGetPluginActionButton.php b/tests/phpunit/tests/admin/includes/wpGetPluginActionButton.php
@@ -84,7 +84,8 @@ public function test_should_return_empty_string_without_proper_capabilities() {
 			true
 		);
 
-		$this->assertSame( '', $actual, 'No button markup should be returned.' );
+		$this->assertIsString( $actual, 'A string should be returned.' );
+		$this->assertSame( '', $actual, 'An empty string should be returned.' );
 	}
 
 	/**
@@ -113,7 +114,8 @@ public function test_should_not_return_empty_string_with_proper_capabilities_sin
 
 		self::$role->remove_cap( $capability );
 
-		$this->assertNotSame( '', $actual, 'Button markup should be returned.' );
+		$this->assertIsString( $actual, 'A string should be returned.' );
+		$this->assertNotSame( '', $actual, 'An empty string should not be returned.' );
 	}
 
 	/**
@@ -147,6 +149,7 @@ public function test_should_not_return_empty_string_with_proper_capabilities_mul
 
 		revoke_super_admin( self::$user_id );
 
-		$this->assertNotSame( '', $actual, 'Button markup should be returned.' );
+		$this->assertIsString( $actual, 'A string should be returned.' );
+		$this->assertNotSame( '', $actual, 'An empty string should not be returned.' );
 	}
 }