Skip to content

Commit

Permalink
Last round of standardising the quotes around variables saved to the …
Browse files Browse the repository at this point in the history
…environment or the output.
  • Loading branch information
johnbillion committed Jan 21, 2025
1 parent cbb8598 commit 52bf13f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/reusable-performance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ jobs:
steps:
- name: Configure environment variables
run: |
echo PHP_FPM_UID="$(id -u)" >> "$GITHUB_ENV"
echo PHP_FPM_GID="$(id -g)" >> "$GITHUB_ENV"
echo "PHP_FPM_UID=$(id -u)" >> "$GITHUB_ENV"

Check failure

Code scanning / octoscan

Write to "$GITHUB_ENV" in a bash script. Error

Write to "$GITHUB_ENV" in a bash script.
echo "PHP_FPM_GID=$(id -g)" >> "$GITHUB_ENV"

Check failure

Code scanning / octoscan

Write to "$GITHUB_ENV" in a bash script. Error

Write to "$GITHUB_ENV" in a bash script.
- name: Checkout repository
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-phpunit-tests-v2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ jobs:
# used for PHP 8 testing instead.
if [ "${LOCAL_PHP}" == '8.0-fpm' ]; then
docker compose run --rm php composer install --ignore-platform-reqs
echo PHPUNIT_SCRIPT="php-composer" >> "$GITHUB_ENV"
echo "PHPUNIT_SCRIPT=php-composer" >> "$GITHUB_ENV"

Check failure

Code scanning / octoscan

Write to "$GITHUB_ENV" in a bash script. Error

Write to "$GITHUB_ENV" in a bash script.
elif [ "${LOCAL_PHP}" == '7.1-fpm' ]; then
docker compose run --rm php composer update
git checkout -- composer.lock
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/slack-notifications.yml
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ jobs:
run: |
# shellcheck disable=SC2016
COMMIT_MESSAGE="$(echo "${COMMIT_MSG_RAW}" | awk 'NR==1' | sed 's/`/\\`/g' | sed 's/\"/\\\\\\"/g' | sed 's/\$/\\$/g')"
echo commit_message_escaped="${COMMIT_MESSAGE}" >> "$GITHUB_OUTPUT"
echo "commit_message_escaped=${COMMIT_MESSAGE}" >> "$GITHUB_OUTPUT"

Check failure

Code scanning / octoscan

Write to "$GITHUB_OUTPUT" in a bash script. Error

Write to "$GITHUB_OUTPUT" in a bash script.
env:
COMMIT_MSG_RAW: ${{ ( github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' ) && fromJson( steps.current-commit-message.outputs.result ) || github.event.head_commit.message }}

Expand Down

0 comments on commit 52bf13f

Please sign in to comment.