Call paste handler #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psrpinto
force-pushed
the
paste-handler
branch
from
7446be3
to
e505c46
Compare
|
Looks very good! We want to use |
|
Pretty good indeed! |
psrpinto
force-pushed
the
paste-handler
branch
from
b7479ff
to
67dd642
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that we call the
pasteHandler()when a user clicks on an element. We don't do anything with the data yet, that will be implemented in future PRs.Build tooling changes
Previously, webpack was always being run in
productionmode, which meant that in development the code was minified and there were no source maps. Now, webpack can also be called indevelopmentmode. We now have the following scripts:build:production: builds both firefox and chrome versions inproductionmode, intobuild/productionbuild:firefox: builds firefox version only, in development mode, intobuild/firefoxbuild:chrome: builds chrome version only, in development mode, intobuild/chromeThe development builds now have source maps, which means we can debug using the browser's debugger.
Screen capture