adds skip links check for block themes #457
Conversation
|
We might want to check if there's multiple tags too |
|
It would be nice to make the |
|
I fixed those! ready for another review |
Co-authored-by: Matias Benedetto <[email protected]>
| $theme_dir = $this->wp_theme->get_stylesheet_directory(); | ||
|
|
||
| // Get all HTML files in the directory | ||
| $files = glob( $theme_dir . '/' . $directory . '/*.html' ); |
There was a problem hiding this comment.
Accessing the file system from the check function doesn't seems to be necesary and it looks like it's not in line with the other implementation. The check function is already getting 3 arrays as parameters containing the list of file paths of the theme.
| return false; | ||
| } | ||
|
|
||
| $files = glob( $theme_dir . '/' . $directory . '/*.php' ); |
There was a problem hiding this comment.
Same as in #457 (comment)
|
I checked by removing Would you please let me know how did you test that? |
I find it. I was checking different PR. Sorry! |
|
REQUIRED Skip links are missing from the following templates: single.html, single.html Please make sure the templates have a tag.Why the message show |
I haven't seen that on my tests, what did you try to get that to happen? |
|
In single.html file of TT4 theme, I simply changed |
|
I think I found the reason, |
| $this->error[] = sprintf( | ||
| '<span class="tc-lead tc-required">%s</span> %s ', | ||
| __( 'REQUIRED', 'theme-check' ), | ||
| sprintf( | ||
| __( 'Skip links are missing from the following templates: %s Please make sure the templates have a <main> tag.', 'theme-check' ), | ||
| $info | ||
| ) | ||
| ); | ||
| } |
There was a problem hiding this comment.
When a REQUIRED change is returned by the check function, it should return false:
See #465 as reference
This PR adds a check only for block themes to see if templates have a main tag present. If they don't they will be missing the skip links from said template.
I need to check when a template is made out of a pattern and the main tag will be inside the pattern instead of the template file