Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin check UX improvement for results #326

Open
wants to merge 23 commits into
base: trunk
Choose a base branch
from
Open

Plugin check UX improvement for results #326

wants to merge 23 commits into from

Conversation

jakaria-istauk
Copy link

@jakaria-istauk jakaria-istauk commented Nov 28, 2023 •
edited by mukeshpanchal27
Loading

Fixes #325

mukeshpanchal27
mukeshpanchal27 requested changes Dec 12, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakaria-istauk for the PR.

  • Ran npm run lint-js -- --fix to fix the JS lint issue and uploaded the changes.
  • Left some feedback that needs to address.

assets/js/plugin-check-admin.js Outdated Show resolved Hide resolved
assets/js/plugin-check-admin.js Outdated Show resolved Hide resolved
templates/results-table.php Outdated Show resolved Hide resolved
@jakaria-istauk
Copy link
Author

hi @mukeshpanchal27 ,
Thanks for your feedback. I gave an update according to your feedback.

@davidperezgar
Copy link
Member

I'd suggest to make an arrow like it works the accordions, so it's minimal interface.
Like this one: <span class="dashicons dashicons-arrow-down-alt2"></span>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin check UX improvement for results
4 participants
@jakaria-istauk @davidperezgar @mukeshpanchal27 @ernilambar