Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin deactivation link color #927

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

felixarntz
Copy link
Member

Summary

The plugin deactivation link is currently bright red (via a simple color: red hard-coded in a style attribute). This is not a good color choice, as it is very bright and doesn't follow the WordPress admin color scheme. It should instead use #b32d2e which is used for other deactivation links on a white background (e.g. in the plugins list table).

This PR fixes that, and as part of it also avoids the style attribute and instead colocates the style with the other styles for the admin page.

This PR uses no milestone to not include it in changelogs, since for end users this bug is not relevant - it only will be if we don't fix it now :)

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@felixarntz felixarntz added [Type] Bug An existing feature is broken Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release Creating standalone plugins [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Jan 10, 2024
admin/plugins.php Outdated Show resolved Hide resolved
@felixarntz felixarntz merged commit d0ee705 into release/2.8.0 Jan 11, 2024
7 checks passed
@felixarntz felixarntz deleted the fix/plugin-deactivate-link-color branch January 11, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Bug An existing feature is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants