Update PHPCS formatting in tests #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
[Type] Enhancement
westonruter
requested review from
pbearne,
spacedmonkey,
manuelRod,
felixarntz,
adamsilverstein and
mukeshpanchal27
as code owners
westonruter
added a commit
that referenced
this pull request
Jan 9, 2024
3 tasks
mukeshpanchal27
approved these changes
Jan 10, 2024
westonruter
added a commit
that referenced
this pull request
Jan 12, 2024
…om/WordPress/performance into add/ilo-background-image-optimization * 'feature/image-loading-optimization' of https://github.com/WordPress/performance: (177 commits) Add additional line breaks in phpdoc Add line break before dataProvider tag Add missing since tag Move ilo_can_optimize_response() to optimization.php Update ilo_verify_url_metrics_storage_nonce() to return bool Re-run composer update with PHP 8.1 Run composer update Fix PHPStan errors in tests Remove scheduler from globals since not yet used Fix or ignore eslint rules Remove modules/images/webp-uploads/fallback.js from ignorePatterns Run format-js on JS files Cherry pick fixes to JS linting from feature/image-loading-optimization Unset REQUEST_URI in tests that call go_to Reset SERVER global after each test Unrevert 2181d88 for audit-enqueued-assets-test.php Prevent sending header during test Unrevert 2181d88 for server-timing-tests.php Revert test changes moved to #924 Manually fix remaining phpcs issues ...
felixarntz
added
the
no milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This cherry-picks changes from #898 to discontinue excluding WordPress-Extra sniffs from applying to tests, and add specific sniff exclusions. By allowing WordPress-Extra to apply, PHPCBF can do automatic formatting. PHPCS errors were fixed in other test files.
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.