Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Auto Sizes for Lazy-loaded Images #904
Add: Auto Sizes for Lazy-loaded Images #904
Changes from 5 commits
9a14b1f
a5e4afa
a7dffc5
97980c1
cab72e1
8e6ef6f
db4a5da
1a88b89
7e3c544
6870baf
d0a19e5
98af1d7
6b3d16d
bd625e8
35e5fbf
3cb88e5
161a738
1ff1004
5f174b7
2fab10a
a5f78b4
8f3c458
d10052f
23bcfc2
edba918
45a8b57
2daf975
88040f2
14c4776
87f3a04
852775d
bc2884f
4b0974e
8cfded4
2a687c7
6901573
6fa9128
f0d74fb
7f3b13b
9addb11
2d0deca
5aeb1c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize you can't (shouldn't?) apply this suggestion here, but this will fix the linting error I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! Handled in #931, which also requires some extra hoops to add the correct labels, etc.
Interestingly our
npm run lint-php
script does not catch this, whilecomposer run lint
does. I'm going to investigate why that is at a later date. I'm not sure what changed upstream that caused the error to show up here in the first place but it's good that it did.