Patterns API: Omit the "featured" category in the REST API #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
added
the
[Component] Pattern Directory API
|
Very nice! |
ryelle
force-pushed
the
remove/featured-cat-api-response
branch
from
e940f4b
to
45ac6ea
Compare
ParhamG
added a commit
to ParhamG/pattern-directory
that referenced
this pull request
Oct 1, 2024
This fixes a regression caused via WordPress#704 that returns category_slugs as an object instead of an array
ryelle
pushed a commit
that referenced
this pull request
Oct 1, 2024
This fixes a regression caused via #704 that returns category_slugs as an object instead of an array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the "featured" category from the API response, so that patterns remotely loaded from the pattern directory will never be included in the "Featured" section of local WordPress sites. This breaks the connection between the Pattern Directory "Featured" category & the "Featured" section of the pattern inserter. Patterns in the featured category on the Pattern Directory will still be sent to WordPress sites, and they will still appear the other categories they have.
For example, Simple call to action has categories "Featured, Buttons", so it will only appear in "Buttons" on local WordPress sites.
Fixes #612.
Props richtabor
How to test the changes in this Pull Request:
/wp-json/wp/v2/wporg-pattern/category_slugsFor easier testing, find the ID for "featured" and use that for the API request,
/wp-json/wp/v2/wporg-pattern/?pattern-categories=CAT_IDor use slugs for individual patterns,/wp-json/wp/v2/wporg-pattern/?slug=offset-images-with-descriptions.There should be no change for non-featured patterns.