Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: make example translatable in query-no-results #68376

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Dec 30, 2024

Part of: #64707
Tracker Comment: #64707 (comment)

What, Why & How?

This PR refactors the example attribute of block.json to support translatable text.

Testing Instructions

  1. Hover over the inserter to see the preview for query-no-results.

Screenshot

Screenshot 2024-12-30 at 10 39 15 AM

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review December 30, 2024 05:10
Copy link

github-actions bot commented Dec 30, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This text isn't actually localized yet, since it's the first time in the whole project, but it should work.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended l10n Localization and translations best practices [Block] No Results Affects the No Results Block - used when a Query Loop returns no results props-bot Adding this label triggers the Props Bot workflow for a PR. labels Jan 2, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 2, 2025
@t-hamano t-hamano merged commit 382af64 into WordPress:trunk Jan 2, 2025
73 of 76 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Jan 2, 2025
bph pushed a commit to bph/gutenberg that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] No Results Affects the No Results Block - used when a Query Loop returns no results l10n Localization and translations best practices [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants