Media & Text: Add caption support #67474
Open
+70
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
Size Change: +290 B (+0.02%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
…edia-text-block-caption-support
akasunil
requested review from
ajitbohra,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @bwoester, @fosterTerence, @Taruks, @AlternNO, @woodz-, @jennsuzhoy, @clarklab, @clo123, @SkipperPit, @alinekeller, @ToniSHernandez, @danwpc, @samrhein, @imsimplyellie, @gregoirenoyelle, @eriwm, @matthiasballreich, @random-pixels, @nicktrosnant, @davidoclubb, @cparkinson, @eilarva, @NolanDolce, @JohanVNR, @androos, @Fturttle. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for working on this. I think this could do with design feedback (cc @WordPress/gutenberg-design). Some questions:
When adding media from Openverse, I believe the caption should be on by default to show the credit (I think it works this way for other media blocks already). The final thing is that theme.json caption element support will I think be needed for this, though I personally don't know much about it. |
|
Nice one. For the first iteration here, I'd make captions consistent with every other caption, such as those on video and image. It's close:
But those other blocks come with a built in top and bottom margin, like so: We need something similar for media & text. Centering is something that a theme designer/developer should be able to do. Whether that happens through elements becoming stylable in global styles (I believe there's a separate issue tracking this), or the Caption becoming an innerblock (#54787). Though for now, I'd ensure consistency with other captions. |
|
Thank you for working on this @akasunil Sunil! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #14604
Why?
Caption support was missing for media in
Media & Textblock.How?
Added caption support for media in
Media & Textblock.Testing Instructions
Media & TextblockUse Featured Imageoption, and verify image caption.Screenshots or screencast