Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native CI tests: update mac os image runners from macos-12 to macos-13 #67095

Open
wants to merge 11 commits into
base: trunk
Choose a base branch
from

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Nov 19, 2024

So basically I don't know what I'm doing.

https://github.com/actions/runner-images is a source of confusion on which xcode version supports which mac os image runner.

According to what I've found:

  1. As of November 2024, the default Xcode version on macos-13 is Xcode 15.0.1 source, and the default Xcode version on macos-14 is Xcode 15.4 source.
  2. macos-13 may default to iOS 17 runtime simulator source. Newer runners support iOS 17 runtime simulator source.

This PR is just a YOLO space. I'll wait for the experts.

What? How?

Update mac os image runners from macos-12 to latest macos-13

Why?

GitHub Actions is starting the deprecation process for macOS 12. While the image is being deprecated, You may experience longer queue times during peak usage hours. Deprecation will begin on 10/7/24 and the image will be fully unsupported by 12/3/24

To raise awareness of the upcoming removal, we will temporarily fail jobs using macOS 12. Builds that are scheduled to run during the brownout periods will fail. The brownouts are scheduled for the following dates and times:

See: actions/runner-images#10721

Testing Instructions

Behold! The native tests should pass 👀 🤞🏻

@ramonjd ramonjd self-assigned this Nov 19, 2024
Copy link

github-actions bot commented Nov 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ramonjd <[email protected]>
Co-authored-by: desrosj <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ramonjd ramonjd added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Nov 19, 2024
if: ${{ github.repository == 'WordPress/gutenberg' || github.event_name == 'pull_request' }}
strategy:
matrix:
xcode: ['14.2']
xcode: ['15.4']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Flaky tests detected in ec6800a.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11904184956
📝 Reported issues:

@desrosj desrosj linked an issue Nov 19, 2024 that may be closed by this pull request
@desrosj
Copy link
Contributor

desrosj commented Nov 19, 2024

"Expert" here (😅), just connecting YOLO prs: #66609. I plan to circle back to this next week after 6.7.1 this week.

@ramonjd
Copy link
Member Author

ramonjd commented Nov 19, 2024

@desrosj Thank you for saving the day!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the version of MacOS used in GitHub Action runners
2 participants