Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synced pattern editing in write mode and refactor block editing mode to reducer #67026

Draft
wants to merge 29 commits into
base: trunk
Choose a base branch
from

Commits on Nov 13, 2024

  1. Add higher order reducer for pattern block editing modes.

    - Remove the prev. React effect for managing pattern block editing modes
    - Implement higher order reducer in the block editor store ... it:
        - Tracks the clientIds of pattern blocks.
        - Uses the pattern block clientIds to manage block editing modes
          for pattern blocks and their inner blocks.
        - Updates both on any actions that change block lists.
    talldan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    4c7653a View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Configuration menu
    Copy the full SHA
    e19dfa3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    828d50c View commit details
    Browse the repository at this point in the history
  3. Bug fixes

    talldan committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8d92546 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Configuration menu
    Copy the full SHA
    758fa60 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e1d6ca4 View commit details
    Browse the repository at this point in the history
  3. Revert "Try moving synced pattern client ids into a separate reducer"

    This reverts commit e1d6ca4.
    
    It doesn't really work, since reducer won't have access to `state.blocks.tree`.
    talldan committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    1721a7a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c40fac0 View commit details
    Browse the repository at this point in the history
  5. Fixes

    talldan committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    edc59fe View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    38ac49c View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Configuration menu
    Copy the full SHA
    ea18275 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    49d0386 View commit details
    Browse the repository at this point in the history
  3. Fix nested pattern handling - always process synced patterns in the r…

    …educer. Add special handling for only adding pattern block itself as content only when not in zoomed out or nav mode
    talldan committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    4378c0d View commit details
    Browse the repository at this point in the history
  4. Zoomed out fixes - content should never be editable in zoomed out, ev…

    …en synced pattern overrides or when write mode is active
    talldan committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    38a3ab3 View commit details
    Browse the repository at this point in the history
  5. Docs

    talldan committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    a43d368 View commit details
    Browse the repository at this point in the history
  6. Add end to end test

    talldan committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    4f44c44 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d636bac View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a599a3d View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Add test for isContentBlock

    talldan committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    60887f7 View commit details
    Browse the repository at this point in the history
  2. Add unit tests

    talldan committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    4ad95bc View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Configuration menu
    Copy the full SHA
    eb11d91 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    06c50db View commit details
    Browse the repository at this point in the history
  3. Remove comment

    talldan committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    9493ab9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b183f7f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c8bcf35 View commit details
    Browse the repository at this point in the history
  6. Fixes and refinements

    talldan committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3dfba9a View commit details
    Browse the repository at this point in the history
  7. Comments and renamings

    talldan committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8207486 View commit details
    Browse the repository at this point in the history
  8. Fix useBlockSync test

    talldan committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    da87cbc View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6f69a32 View commit details
    Browse the repository at this point in the history