-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments Pagination: Add border and spacing support #66470
base: trunk
Are you sure you want to change the base?
Comments Pagination: Add border and spacing support #66470
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hi |
The block also needs |
Sure! @carolinan |
I was reading through the comments of similar pull requests, like for the RSS block, and I believe both the spacing controls and the border should be hidden by default. The same goes for the other pagination PR's. |
I didn't get this point, Can you please elaborate more? |
Because these pagination blocks are blocks that are not primarily used for design, but to display the pagination, The visibility is controlled in block.json.
The border controls are hidden by default, so the I understand that multiple change requests can be annoying, but I have one more idea. Since this block has three inner blocks by default, how about also enabling the block gap? Example: |
What?
Add border block support to the comments pagination block.
Part of #43247
Part of #43243
Why?
The comments pagination block is missing border support.
How?
Adds the border block support in block.json
Testing Instructions