Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments Pagination: Add border and spacing support #66470

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

rinkalpagdar
Copy link
Contributor

What?

Add border block support to the comments pagination block.
Part of #43247
Part of #43243

Why?

The comments pagination block is missing border support.

How?

Adds the border block support in block.json

Testing Instructions

  1. Go to the Global Styles setting ( under appearance > editor > styles > edit styles > blocks )
  2. Make sure that the comments pagination block's border and spacing are configurable via Global Styles
  3. Verify that Global Styles are applied correctly in the editor and frontend
  4. Edit the template/page, Add a comments pagination block and Apply the border and spacing styles
  5. Verify that block styles take precedence over global styles
  6. Verify that block borders and spacing display correctly in both the editor and frontend

Copy link

github-actions bot commented Oct 25, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rinkalpagdar <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@akasunil akasunil added the [Type] Enhancement A suggestion for improvement. label Oct 29, 2024
@shail-mehta shail-mehta added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Dec 25, 2024
@carolinan
Copy link
Contributor

Hi
Can you refresh this so that it includes the changes from trunk?

@carolinan
Copy link
Contributor

The block also needs box-sizing: border-box; added to the CSS, so that borders and padding doesn't increase the width.
You can find an example with a video here: #63630

@rinkalpagdar
Copy link
Contributor Author

Sure! @carolinan

@carolinan
Copy link
Contributor

I was reading through the comments of similar pull requests, like for the RSS block, and I believe both the spacing controls and the border should be hidden by default.
Example: https://github.com/WordPress/gutenberg/pull/66411/files#diff-7b8efb131b353e99335a969203806dab22212e9fc899e16c13315c68d78227afR59

The same goes for the other pagination PR's.

@rinkalpagdar
Copy link
Contributor Author

I was reading through the comments of similar pull requests, like for the RSS block, and I believe both the spacing controls and the border should be hidden by default. Example: https://github.com/WordPress/gutenberg/pull/66411/files#diff-7b8efb131b353e99335a969203806dab22212e9fc899e16c13315c68d78227afR59

The same goes for the other pagination PR's.

I didn't get this point, Can you please elaborate more?

@carolinan
Copy link
Contributor

carolinan commented Jan 23, 2025

I was reading through the comments of similar pull requests, like for the RSS block, and I believe both the spacing controls and the border should be hidden by default. Example: https://github.com/WordPress/gutenberg/pull/66411/files#diff-7b8efb131b353e99335a969203806dab22212e9fc899e16c13315c68d78227afR59
The same goes for the other pagination PR's.

I didn't get this point, Can you please elaborate more?

Because these pagination blocks are blocks that are not primarily used for design, but to display the pagination,
the spacing and border controls should be hidden until the user enables them using the option.
This helps reduce the cognitive load by showing fewer settings.

The visibility is controlled in block.json.
The padding and margin controls are visible by default, and to hide them, __experimentalDefaultControls needs to be false:

"__experimentalDefaultControls": {
	"padding": false,
	"margin": false
}

The border controls are hidden by default, so the __experimentalDefaultControls should be removed.


I understand that multiple change requests can be annoying, but I have one more idea.

Since this block has three inner blocks by default, how about also enabling the block gap?
That way, we can adjust the space between the blocks when the block has the vertical orientation enabled, and we have more control of the space in the horisontal orientation.
What do you think?

Example: "blockGap": [ "horizontal", "vertical" ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants