Add new private upload-media package
#66290
Open
+2,449
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
[Type] Build Tooling
swissspidy
force-pushed
the
add/61447-upload-media-pkg
branch
3 times, most recently
from
ad143dc
to
1851a20
Compare
|
Size Change: +3.89 kB (+0.21%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
swissspidy
force-pushed
the
add/61447-upload-media-pkg
branch
from
1851a20
to
b99c449
Compare
swissspidy
force-pushed
the
add/61447-upload-media-pkg
branch
from
b99c449
to
8a57140
Compare
swissspidy
commented
Oct 21, 2024
package.json
Outdated
| @@ -310,7 +311,7 @@ | |||
| "lint:pkg-json": "wp-scripts lint-pkg-json . 'packages/*/package.json'", | |||
| "native": "npm run --prefix packages/react-native-editor", | |||
| "other:changelog": "node ./bin/plugin/cli.js changelog", | |||
| "other:check-licenses": "concurrently \"wp-scripts check-licenses --prod --gpl2 --ignore=@react-native-community/cli,@react-native-community/cli-platform-ios,@ampproject/remapping,human-signals,fb-watchman,walker,chrome-launcher,lighthouse-logger,chromium-edge-launcher\" \"wp-scripts check-licenses --dev\"", | |||
| "other:check-licenses": "concurrently \"wp-scripts check-licenses --prod --gpl2 --ignore=@react-native-community/cli,@react-native-community/cli-platform-ios,@ampproject/remapping,human-signals,fb-watchman,walker,chrome-launcher,lighthouse-logger,chromium-edge-launcher,webpack\" \"wp-scripts check-licenses --dev\"", | |||
There was a problem hiding this comment.
For some reason the Apache-licensed @webassemblyjs/leb128 and @xtuc/long packages, which are dependencies of webpack, were being flagged. No idea why this happened only when working on this PR.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
reviewed
Oct 22, 2024
An oversight. Added now. FWIW this is all coming from https://github.com/swissspidy/media-experiments if anyone wants to see the full context of how everything works together. |
3 tasks
youknowriad
reviewed
Oct 24, 2024
youknowriad
reviewed
Oct 24, 2024
* Fix: JSON Schema Docgen doesn't work on Windows OS * Update bin/api-docs/gen-theme-reference.mjs Co-authored-by: Jon Surrell <[email protected]> * Lint --------- Co-authored-by: t-hamano <[email protected]> Co-authored-by: sirreal <[email protected]>
* Contain margins with BFC instead of border * Move to block canvas styles in the visual editor --------- Co-authored-by: Andrew Serong <[email protected]> Co-authored-by: stokesman <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: t-hamano <[email protected]>
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: stokesman <[email protected]>
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]>
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ramonjd <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
|
In swissspidy/media-experiments#753 I am experimenting with inlining the wasm files, and in swissspidy/media-experiments#754 I am experimenting with turning the After that, it should be possible to explore an alternative web worker implementation building on top of that. But I'd really appreciate help with that :) |
|
I've been away and am a bit swamped, but I may be able to support the script-modules efforts if that would be helpful. |
|
I'll take any help I can get! 🙏 |
|
@youknowriad @sirreal @gziolo Would it be possible to move forward by merging this one for now and making any subsequent changes to the whole wasm and web worker thing in subsequent PRs? Feels like it would otherwise be stuck forever 😕 |
Co-authored-by: Jon Surrell <[email protected]>
|
@youknowriad @gziolo @sirreal I've now reduced this PR for the media upload queue to the bare minimum, without any of the actual client-side processing/cropping/resizing logic whatsoever. Just hooking up this new package to the block-editor package—all behind the experimental flag of course. PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a new package for client-side media processing, see #61447.
This package has been tested extensively as part of https://github.com/swissspidy/media-experiments, but for this PR several features have been removed. They will be reintroduced at a later stage in separate PRs to make reviews easier.
The package is private and shall not be published until later on when all of the subsequent PRs are merged.
Why?
Required for a new era of upload handling in Gutenberg
How?
Adds a new package to facilitate integration in the block-editor package
Testing Instructions
Unit tests should pass.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A