Fix focus from zoom inserter #66256
Merged
Fix focus from zoom inserter #66256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
force-pushed
the
fix/focus-from-zoom-inserter
branch
from
165d2e7 to
05ea598
Compare
|
Size Change: +29 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
kevin940726
added
[Focus] Accessibility (a11y)
kevin940726
approved these changes
Oct 21, 2024
getdave
reviewed
Oct 21, 2024
There was a problem hiding this comment.
The code works as described and I appreciate the logic for needing to move the focus.
What I'm not sure on is if this is expected behaviour for keyboard users?
I assume the optimal fix would be to move focus when the ENTER is pressed? But because the inserter is already opened we cannot do that.
I explore trying to create a command to re-focus the inserter search but I didn't have any success. I think it's a wider issue of us needing a means of focusing specific parts of the editor UI programmatically.
As I don't have enough expertise, I'd like to get some a11y reviews on this one if possible. I appreciate you do have expertise so if you advise that this approach is justifiable I would be happy enough moving forward.
@kevin940726 what do you think?
|
This doesn't have to land in RC1. It fixes a bug introduced during 6.7 cycle so we can legitimately land it for RC2 when we're confident it's the right fix. |
draganescu
approved these changes
Oct 21, 2024
draganescu
added
the
Backport to WP 6.7 Beta/RC
ajlende
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
I'm not sure why we shouldn't fix it also on trunk too?
This isn't the right fix for trunk. A "proper" fix would require passing around refs which isn't a trivial change. So for 6.7 this is good, but the bug should be fixed properly on trunk instead of just backporting this.
|
Ok folks. There are enough 👍 here that this is a good enough patch for 6.7. I agree with the need for a more comprehensive fix in |
kevin940726
added
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If the inserter (block library) is already open, clicking the Add pattern button from the canvas does not move focus.
Why?
The block inserter receives focus on mount, but if it's already mounted, there isn't a way to move focus to it.
How?
This adds a
document.querySelector( '[aria-label="Block Library"]' )?.focus()in the Add patternonClickto send focus to the inserter if it is already open.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Recording.2024-10-18.at.1.12.39.PM.mov