Style Book: Add color tab #65692
Merged
Style Book: Add color tab #65692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +968 B (+0.05%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
ramonjd
force-pushed
the
try/style-book-refactor-categories-and-blocks
branch
from
3cd9a76 to
032182e
Compare
Base automatically changed from
try/style-book-refactor-categories-and-blocks
to
trunk
September 30, 2024 07:40
aaronrobertshaw
force-pushed
the
add/style-book-colors-tab
branch
2 times, most recently
from
c7b94b2 to
2874f35
Compare
19 tasks
ramonjd
reviewed
Oct 11, 2024
aaronrobertshaw
force-pushed
the
add/style-book-colors-tab
branch
2 times, most recently
from
79365b4 to
36561f8
Compare
ramonjd
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Another fly by test.
I think this is in a very good place. Awesome work.
I couldn't perceive any performance regressions - clicking between tabs is snappy.
Also the colors updates on all style changes. That the colors/gradients don't open their respective tabs in the panel isn't a problem for the first round I reckon.
aaronrobertshaw
force-pushed
the
add/style-book-colors-tab
branch
from
36561f8 to
92dbe8f
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for keeping an eye on this @ramonjd, very much appreciated 🙇 I've finally had a chance to chip away at the last few rough edges. So if you're happy regarding the general direction as an MVP for the Style Book color tab, I am. In that spirit, I've flagged this for a proper review. |
|
Flaky tests detected in 4d4a095. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11453617073
|
aaronrobertshaw
changed the title
ramonjd
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Fantastic work @aaronrobertshaw . I think this is good to go as a first version.
Pretty snappy and the real-time updates for custom colors/gradients are 💯
Kapture.2024-10-22.at.15.35.47.mp4
|
Thanks for the review and testing @ramonjd 🚀 I'll get the conflict resolved and merge. |
…xample" This reverts commit eb74467.
aaronrobertshaw
force-pushed
the
add/style-book-colors-tab
branch
from
4103d7f to
4d4a095
Compare
This was referenced Oct 25, 2024
benazeer-ben
added a commit
to benazeer-ben/gutenberg
that referenced
this pull request
Oct 25, 2024
This reverts commit 5437114.
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: ramonjd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of:
Depends on:
What?
Adds a "Color" tab to the Style Book.
Why?
An important aspect of a theme's styles are its available colors, gradients, and duotone filters. The proposed color tab for the style book provides a means through which these can be displayed alongside other global styles for blocks.
See #53431 for further context.
How?
examples.tstoexamples.tsxand adds/updates utils for generating color tab examplesTesting Instructions
To save some extra configuration to see all the various types of color examples activate a theme such as TT2 that defines not only color palettes but also duotones, gradients, and keeps default palettes enabled.
Screenshots or screencast
Screen.Recording.2024-10-16.at.5.48.03.pm.mp4