-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move duplicateTemplatePart
action to the @wordpress/fields
package
#65390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
commented
Sep 17, 2024
packages/fields/src/components/create-template-part-modal/index.tsx
Outdated
Show resolved
Hide resolved
This PR is ready to be reviewed! cc @oandregal @youknowriad @louwie17 |
youknowriad
reviewed
Nov 29, 2024
youknowriad
reviewed
Nov 29, 2024
youknowriad
reviewed
Nov 29, 2024
youknowriad
reviewed
Dec 3, 2024
youknowriad
reviewed
Dec 3, 2024
youknowriad
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM
Thanks for your review! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR migrates the
duplicateTemplatePart
action to the@wordpress/fields
package. The primary issue with this action is its dependency on theCreateTemplatePartModalContents
component, which resides in the@wordpress/editor
package. Due to this, it can't be directly used within the@wordpress/fields
package.For the purpose of the
@wordpress/fields
package work, I have temporarily moved the component to this package. However, I'm not certain if this is the best long-term solution. Ideally, this component (and potentially others) should reside in a dedicated package, such as@wordpress/template
, which would be more appropriate for components related to template and template-parts. A similar package for the patterns already exists: https://github.com/WordPress/gutenberg/blob/d6fcf4aea4aff17cf0910862bf10090e20ba2ab0/packages/patterns/srcPlease review and provide feedback on whether this approach is suitable or if there are alternative recommendations for handling these dependencies. Thanks! 🙏 cc @youknowriad @oandregal
Testing Instructions
Ensure that
Custom Dataviews
is enabled.Testing Instructions for Keyboard
Screenshots or screencast