File block: Do not persist blob urls and fix undo #63282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +57 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Jul 9, 2024
ellatrix
reviewed
Jul 9, 2024
| } ); | ||
| setTemporaryURL(); |
There was a problem hiding this comment.
I wonder if it might make sense to have a helper util for this
There was a problem hiding this comment.
I think there's a lot of duplication between how these media blocks are setup, a lot could be share but there are also some things that are to explain: some use "url" others "href" and others "src" for the uploaded files
|
This is the last one :) |
|
The Cover and Media & Text block might need an audit as well. I've not worked on these blocks in a while, but anything using |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: ellatrix <[email protected]>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: ellatrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #39223
Similar to #63076 and #63238
What?
In #63076, we introduced the concept of local attributes to allow setting attributes that won't be persisted. It's useful during file uploads for instance where we want immediate user feedback but without impacting the saved post.
In the previous PR, we implemented it for image, audio and video blocks and this PR does the same for the file block. This PR also fixes an undo bug in the file block.
Testing Instructions
1- Throttle your network speed (that way uploading file will take a long time)
2- Drag and drop a pdf file into the post editor.
3- Save the post immediately.
4- Open the post in a new tab and notice that the inserted file block is actually empty.
5- Go back to the old tab, and wait until the upload completes.
6- Notice that the file block has been updated properly with the right URL.
You can also try undoing uploads and it should results in empty file blocks.