Add a delete control to toolbar on zoom-out mode #60214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +53 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
The delete button is available on the Header and Footer. Is that a good idea? |
scruffian
approved these changes
Mar 27, 2024
Do we need to worry about that if #59249 lands? |
That'll land, but it won't limit selection of header and footer template parts.
Let's keep a close eye on this; it may be appropriate to not delete headers/footers. |
Actually, let's go ahead and omit the template parts from this. You can't edit them anyhow from the page perspective, the control does not do anything when viewing a page in the site editor. |
|
Does the trash icon render for locked blocks that cannot be deleted? |
draganescu
force-pushed
the
add-delete-button-toolbar
branch
from
edc4686
to
3851375
Compare
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
* add a delete button to zoomed out mode toolbar * remove delete button from template parts * don's show the remove button if block can't be removed --------- Co-authored-by: MaggieCabrera <[email protected]> Co-authored-by: draganescu <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: richtabor <[email protected]>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #60121
Adds a delete button to the BlockSelectionButton toolbar
Why?
So we don't need to move out from zoom out mode if we insert the wrong pattern to delete it
Testing Instructions
In the site editor, click zoom-out mode.
Select one of the sections, the button should show on the toolbar and it should work as expected.
Screenshots or screencast