Prevent reordering of header and footer template parts when zoomed out #60054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -113 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
draganescu
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…s for immediate siblings blocks
draganescu
force-pushed
the
add/remove-move-ui-for-zoom-out-near-header-footer
branch
from
38b6c7e
to
bca7a8b
Compare
|
I'm not sure about the single movers: 
What do you think about leaving them there, but in a disabled state? |
Good idea I can try |
scruffian
reviewed
Mar 22, 2024
packages/block-editor/src/components/block-tools/block-selection-button.js
Outdated
Show resolved
Hide resolved
|
When a block is the first in the tree the up button is already disabled so we should be able to share some logic with that maybe: 
|
scruffian
reviewed
Mar 22, 2024
scruffian
reviewed
Mar 22, 2024
| const { name: nextName } = getBlock( nextClientId ); | ||
| const nextBlockType = getBlockType( nextName ); | ||
| isNextBlockTemplatePart = | ||
| nextBlockType?.name === 'core/template-part'; |
There was a problem hiding this comment.
I think we should check if it's a header / footer template area too. This would stop us moving all blocks either side of any template part.
There was a problem hiding this comment.
The area check was my initial idea but it's so weirdly saved as a piece of info. Then I realised all template parts should be stuck in place in composer mode.
richtabor
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Tests well; preventing moving of blocks above and below the site header and footer, when in zoom out mode. With another code review opinion, I'm good with it.
It'll come together further when #59249 is merged as well, which will allow for top-level block selection where expected.
draganescu
deleted the
add/remove-move-ui-for-zoom-out-near-header-footer
branch
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
WordPress#60054) * don't show movers in zoom out for template parts, try to remove movers for immediate siblings blocks * fix bug because of typo in function name * don't hide the movers, disable them * rename props to be more generic
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
WordPress#60054) * don't show movers in zoom out for template parts, try to remove movers for immediate siblings blocks * fix bug because of typo in function name * don't hide the movers, disable them * rename props to be more generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Advances #50739
Why?
To improve the experience of assembling pages and templates using patterns.
How?
Check block type and disable block mover for the block toolbar that appears in zoom out mode.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
disable-move-header-footer.mp4