-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the template preview menu item text in the Template option #57802
Update the template preview menu item text in the Template option #57802
Conversation
…the summary panel
Size Change: -1 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in a7aa903. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7897985834
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix is working as expected. Code looks good.
Screen.Recording.2024-02-22.at.16.43.49.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the action-oriented copy. This UI/X is still a bit rough around the edges. It's very hard to scan it, with "template" appended to each of the items above. I wonder if there's an improvement we can consider following up on.
What?
This is a text change in the Template option in the Summary panel in the Page settings panel.
The text in the menu item that toggles the visibility of the template is changed from "Template preview" to "Show template".
Why?
The current text can be confusing, see #56269
Testing Instructions
Go to Editor > Appearance > Pages
Select a page to edit.
Open the Page tab in the settings panel.
Open the Summary panel.
Click on the template name next to "Template"
A popup with a menu opens. Confirm that the last item in the menu is "Show template".
Screenshots or screencast
After: