Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Address NullPointerException crash in AztecHeadingSpan #56757

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Dec 4, 2023

Related PRs

What?

This PR updates the referenced version of Aztec for Android. That referenced version includes a potential fix for the crash described at wordpress-mobile/WordPress-Android#18657.

Why?

It's necessary to update the reference in order to include the potential crash fix in Gutenberg.

How?

Full details of the changes to Aztec can be found at wordpress-mobile/AztecEditor-Android#1071. It is the changes in that PR that will be included in Gutenberg.

Testing Instructions

  1. Using the installable build available from Address NullPointerException crash in AztecHeadingSpan wordpress-mobile/WordPress-Android#19724, install the app and navigate to the post editor.
  2. Add some heading blocks and ensure there are no unexpected side effects when performing tasks. Example tasks to test include splitting the block, applying new font sizes and line heights, etc.

@SiobhyB SiobhyB added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Mobile App - Automation Label used to initiate Mobile App PR Automation labels Dec 4, 2023
@SiobhyB SiobhyB changed the title [RNMobile] Address NullPointerException crash in AztecHeadingSpan [RNMobile] Address NullPointerException crash in AztecHeadingSpan Dec 4, 2023
@SiobhyB SiobhyB marked this pull request as ready for review December 4, 2023 15:51
@SiobhyB SiobhyB requested a review from fluiddot December 4, 2023 15:51
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SiobhyB SiobhyB merged commit a2b7ac2 into trunk Dec 4, 2023
51 checks passed
@SiobhyB SiobhyB deleted the rnmobile/aztec-nullpointerexception-heading-crash branch December 4, 2023 19:15
@github-actions github-actions bot added this to the Gutenberg 17.3 milestone Dec 4, 2023
fluiddot pushed a commit that referenced this pull request Dec 5, 2023
…#56757)

Address rare cases where a null value is passed to a heading block, causing a crash.
fluiddot added a commit that referenced this pull request Dec 5, 2023
* Release script: Update react-native-editor version to 1.109.0

* Release script: Update CHANGELOG for version 1.109.0

* Release script: Update podfile

* Update `react-native-editor` changelog

* Update `react-native-editor` changelog

* Mobile - Fix issue when backspacing in an empty Paragraph block (#56496)

* Bring changes from #55134 to the mobile code

* Mobile - RichText - Force focus when the block is selected but the textinput is not, for cases when merging blocks.

* Update Buttons integration test due to a change in the logic of the app where deleting the only button available does not remove the block

* Mobile - Heading block - Adds integration test for merging a Heading block with an empty Paragraph block

* Mobile - Paragraph block - Adds integration test to check that backspacing in an empty Paragraph block merges succesfully with the previous block and keeps the focus on the TextInput

* Mobile - RichText - Set selection values to be the last character position when merging and adds some comments to explain what is doing

* Mobile - Paragraph block test - Use focusTextInput to check the TextInput is in focused instead of checking for the fomatting toolbar button

* Rename shouldFocusTextInputAfterUpdate to shouldFocusTextInputAfterMerge

* Update CHANGELOG

* Release script: Update react-native-editor version to 1.109.1

* Release script: Update CHANGELOG for version 1.109.1

* Release script: Update podfile

* [RNMobile] Fixes a crash on pasting MS Word list markup (#56653)

* Add polyfill for Element.prototype.remove

* Enable unit tests of `raw-handling` API filter `ms-list-converter`

* Update `react-native-editor` changelog

* [RNMobile] Fix issue related to receiving undefined ref in text color format (#56686)

* Fix issue related to receiving undefined ref in text color format

In rare cases, `TextColorEdit` might receive the `RichText` ref as undefined. This ref is used to get the background color of the text and use it in the toolbar button.

* Update `react-native-editor` changelog

* Add test to cover undefined `contentRef` case

* Correct typo in `changelog`

* [RNMobile] Fix HTML to blocks conversion when no transformations are available (#56723)

* Add native workaround for HTML block in `htmlToBlocks`

* Add raw handling tests

This file is a clone of the same `blocks-raw-handling.js` file located in `gutenberg/test/integration`. The reason for the separation is that several of the test cases fail in the native version. For now, we are going to skip them, but we'd need to work on them in the future.
Once all issues in tests are addressed, we'll remove this file in favor of the original one.

* Update blocks raw handling test snapshot with original values

* Disable more pasteHandler test cases due to not matching test snapshot

* Comment obsolete snapshots of blocks raw handling tests

The reason for commenting them instead of removing is that, in the future, we'll restore them once we address the failing test cases.

* RichText (native): remove HTML check in getFormatColors (#56684)

* Mobile - Global Styles - Fix issue with custom color variables not being parsed (#56752)

* [RNMobile] Address `NullPointerException` crash in `AztecHeadingSpan` (#56757)

Address rare cases where a null value is passed to a heading block, causing a crash.

* Release script: Update react-native-editor version to 1.109.2

* Release script: Update CHANGELOG for version 1.109.2

* Release script: Update podfile

---------

Co-authored-by: Gerardo Pacheco <[email protected]>
Co-authored-by: Ella <[email protected]>
Co-authored-by: Siobhan Bamber <[email protected]>
SiobhyB pushed a commit that referenced this pull request Dec 14, 2023
* Release script: Update react-native-editor version to 1.109.0

* Release script: Update CHANGELOG for version 1.109.0

* Release script: Update podfile

* Update `react-native-editor` changelog

* Update `react-native-editor` changelog

* Mobile - Fix issue when backspacing in an empty Paragraph block (#56496)

* Bring changes from #55134 to the mobile code

* Mobile - RichText - Force focus when the block is selected but the textinput is not, for cases when merging blocks.

* Update Buttons integration test due to a change in the logic of the app where deleting the only button available does not remove the block

* Mobile - Heading block - Adds integration test for merging a Heading block with an empty Paragraph block

* Mobile - Paragraph block - Adds integration test to check that backspacing in an empty Paragraph block merges succesfully with the previous block and keeps the focus on the TextInput

* Mobile - RichText - Set selection values to be the last character position when merging and adds some comments to explain what is doing

* Mobile - Paragraph block test - Use focusTextInput to check the TextInput is in focused instead of checking for the fomatting toolbar button

* Rename shouldFocusTextInputAfterUpdate to shouldFocusTextInputAfterMerge

* Update CHANGELOG

* Release script: Update react-native-editor version to 1.109.1

* Release script: Update CHANGELOG for version 1.109.1

* Release script: Update podfile

* [RNMobile] Fixes a crash on pasting MS Word list markup (#56653)

* Add polyfill for Element.prototype.remove

* Enable unit tests of `raw-handling` API filter `ms-list-converter`

* Update `react-native-editor` changelog

* [RNMobile] Fix issue related to receiving undefined ref in text color format (#56686)

* Fix issue related to receiving undefined ref in text color format

In rare cases, `TextColorEdit` might receive the `RichText` ref as undefined. This ref is used to get the background color of the text and use it in the toolbar button.

* Update `react-native-editor` changelog

* Add test to cover undefined `contentRef` case

* Correct typo in `changelog`

* [RNMobile] Fix HTML to blocks conversion when no transformations are available (#56723)

* Add native workaround for HTML block in `htmlToBlocks`

* Add raw handling tests

This file is a clone of the same `blocks-raw-handling.js` file located in `gutenberg/test/integration`. The reason for the separation is that several of the test cases fail in the native version. For now, we are going to skip them, but we'd need to work on them in the future.
Once all issues in tests are addressed, we'll remove this file in favor of the original one.

* Update blocks raw handling test snapshot with original values

* Disable more pasteHandler test cases due to not matching test snapshot

* Comment obsolete snapshots of blocks raw handling tests

The reason for commenting them instead of removing is that, in the future, we'll restore them once we address the failing test cases.

* RichText (native): remove HTML check in getFormatColors (#56684)

* Mobile - Global Styles - Fix issue with custom color variables not being parsed (#56752)

* [RNMobile] Address `NullPointerException` crash in `AztecHeadingSpan` (#56757)

Address rare cases where a null value is passed to a heading block, causing a crash.

* Release script: Update react-native-editor version to 1.109.2

* Release script: Update CHANGELOG for version 1.109.2

* Release script: Update podfile

* Release script: Update react-native-editor version to 1.109.3

* Release script: Update CHANGELOG for version 1.109.3

* Release script: Update podfile

* Mobile - Fix having the default font sizes when there are theme font sizes available

* Update CHANGELOG entry

---------

Co-authored-by: Carlos Garcia <[email protected]>
Co-authored-by: Gerardo Pacheco <[email protected]>
Co-authored-by: Ella <[email protected]>
artemiomorales pushed a commit that referenced this pull request Jan 4, 2024
* Release script: Update react-native-editor version to 1.109.0

* Release script: Update CHANGELOG for version 1.109.0

* Release script: Update podfile

* Update `react-native-editor` changelog

* Update `react-native-editor` changelog

* Mobile - Fix issue when backspacing in an empty Paragraph block (#56496)

* Bring changes from #55134 to the mobile code

* Mobile - RichText - Force focus when the block is selected but the textinput is not, for cases when merging blocks.

* Update Buttons integration test due to a change in the logic of the app where deleting the only button available does not remove the block

* Mobile - Heading block - Adds integration test for merging a Heading block with an empty Paragraph block

* Mobile - Paragraph block - Adds integration test to check that backspacing in an empty Paragraph block merges succesfully with the previous block and keeps the focus on the TextInput

* Mobile - RichText - Set selection values to be the last character position when merging and adds some comments to explain what is doing

* Mobile - Paragraph block test - Use focusTextInput to check the TextInput is in focused instead of checking for the fomatting toolbar button

* Rename shouldFocusTextInputAfterUpdate to shouldFocusTextInputAfterMerge

* Update CHANGELOG

* Release script: Update react-native-editor version to 1.109.1

* Release script: Update CHANGELOG for version 1.109.1

* Release script: Update podfile

* [RNMobile] Fixes a crash on pasting MS Word list markup (#56653)

* Add polyfill for Element.prototype.remove

* Enable unit tests of `raw-handling` API filter `ms-list-converter`

* Update `react-native-editor` changelog

* [RNMobile] Fix issue related to receiving undefined ref in text color format (#56686)

* Fix issue related to receiving undefined ref in text color format

In rare cases, `TextColorEdit` might receive the `RichText` ref as undefined. This ref is used to get the background color of the text and use it in the toolbar button.

* Update `react-native-editor` changelog

* Add test to cover undefined `contentRef` case

* Correct typo in `changelog`

* [RNMobile] Fix HTML to blocks conversion when no transformations are available (#56723)

* Add native workaround for HTML block in `htmlToBlocks`

* Add raw handling tests

This file is a clone of the same `blocks-raw-handling.js` file located in `gutenberg/test/integration`. The reason for the separation is that several of the test cases fail in the native version. For now, we are going to skip them, but we'd need to work on them in the future.
Once all issues in tests are addressed, we'll remove this file in favor of the original one.

* Update blocks raw handling test snapshot with original values

* Disable more pasteHandler test cases due to not matching test snapshot

* Comment obsolete snapshots of blocks raw handling tests

The reason for commenting them instead of removing is that, in the future, we'll restore them once we address the failing test cases.

* RichText (native): remove HTML check in getFormatColors (#56684)

* Mobile - Global Styles - Fix issue with custom color variables not being parsed (#56752)

* [RNMobile] Address `NullPointerException` crash in `AztecHeadingSpan` (#56757)

Address rare cases where a null value is passed to a heading block, causing a crash.

* Release script: Update react-native-editor version to 1.109.2

* Release script: Update CHANGELOG for version 1.109.2

* Release script: Update podfile

* Release script: Update react-native-editor version to 1.109.3

* Release script: Update CHANGELOG for version 1.109.3

* Release script: Update podfile

* Mobile - Fix having the default font sizes when there are theme font sizes available

* Update CHANGELOG entry

---------

Co-authored-by: Carlos Garcia <[email protected]>
Co-authored-by: Gerardo Pacheco <[email protected]>
Co-authored-by: Ella <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - Automation Label used to initiate Mobile App PR Automation Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants