Shortcode Block: fix layout margin override #55028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: -123 B (-0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
t-hamano
commented
Oct 4, 2023
Comment on lines
-1
to
-5
| [data-type="core/shortcode"] { | ||
| &.components-placeholder { | ||
| min-height: 0; | ||
| } | ||
| } |
There was a problem hiding this comment.
This style is intended to override the Placeholder's minimum height. However, since min-height has been removed in #54216, it is no longer needed.
|
Flaky tests detected in dda69a8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6402001168
|
t-hamano
force-pushed
the
shortcode/layout-margin-override
branch
from
dda69a8 to
8aff2e6
Compare
t-hamano
force-pushed
the
shortcode/layout-margin-override
branch
from
8aff2e6 to
7a86e2a
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
force-pushed
the
shortcode/layout-margin-override
branch
from
7a86e2a to
be42fea
Compare
t-hamano
force-pushed
the
shortcode/layout-margin-override
branch
from
be42fea to
8180df0
Compare
tellthemachines
approved these changes
May 13, 2024
There was a problem hiding this comment.
Thanks for fixing this @t-hamano! It's working well for me and it makes total sense to use the same placeholder component as all the other blocks.
One thing that I noticed while testing is that on pasting a URL into the shortcode textarea the whole block is transformed into a Paragraph. I can reproduce it on trunk (so it's not a side-effect of this PR) but I can't on WP 6.5.3. This must have been a fairly recent change? but no idea what caused it. I was testing with the wp audio shortcode, which takes a src attribute.
|
@tellthemachines Thanks for the review!
Yes, this is a regression happening with the latest Gutenberg 😅 This issue has been reported on #61377. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes an issue where the shortcode block's
margin:0is prioritized and layout margins are not applied.Why?
This Shortcode block has a wrapper div given the
component-placeholderclass, and this component has zero margin.This margin was previously probably overridden by layout margins. However, this problem came to light because #47858 lowered the level of detail of the selector.
How?
I added a div element inside the block and gave it thecomponents-placeholderclass.Ideally, it could be refactored using aPlaceholdercomponent, similar to RSS blocks, Embed blocks, etc. However, the label size changes significantly, so I've only fixed the margins for now. As a follow-up to this PR, weu may be able to replace it with a Placeholder component and adjust the style.#59275 improved the
Placeholdercomponent and unified the label size to a smaller size. With this, I was able to completely replace it with thePlaceholdercomponent.Testing Instructions
Insert multiple shortcode blocks and make sure margins are applied between the blocks.