Library: Reinstate sidebar navigation menu editing for template parts #51825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
|
Size Change: +264 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3200c6fe97cda080c80f4dd8b6961a97cbef7e9e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5352132622
|
glendaviesnz
approved these changes
Jun 23, 2023
aaronrobertshaw
force-pushed
the
fix/reinstate-nav-menu-editing-for-template-parts
branch
from
3200c6f
to
734e024
Compare
aaronrobertshaw
deleted the
fix/reinstate-nav-menu-editing-for-template-parts
branch
|
Thanks for follow up and getting this sorted so quickly 👍 One thing that struck me is that now the sidebar is auto-collapsed this does make the Navigation feature harder to find. Does it have to be collapsed now that we have valuable content in the sidebar? |
@getdave Do you have a screenshot of what's changed? |
|
Here I am entering focus mode and the sidebar is always hidden). Maybe that's because I'm not entering focus mode via Browse Mode sidebar (see below for why): Screen.Capture.on.2023-06-23.at.10-04-02.mp4More concerning however is that I can't even seem to access my Screen.Capture.on.2023-06-23.at.10-05-26.mp4 |
|
Thanks for the details. I'm not sure about why it's collapsed now, @aaronrobertshaw might know more.
Seems like a bug that template parts can't be clicked on to get to focus mode. Thanks for spotting it. |
Seems like it was this way before the library PR too when you edit template parts this way.
I think I may have broken this in #51830, it's out of hours now for me so I'll work on a fix on Monday. Having said that, if I check out the commit to trunk before that PR was merged, the sidebar is still collapsed when accessing template parts. I don't if there was a particular decision around that, let's see. |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Reinstates the recent addition of navigation menu editing in the site editor's sidebar navigation screens for template parts.
Why?
It was inadvertently removed when the Library was implemented as it wasn't in those designs.
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-06-23.at.12.03.25.pm.mp4