Prevent block overlay on blocks with a 'contentOnly' editing mode #51780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Bug
|
Size Change: +4 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6805719f274663e9abb9e25f369dd0bc9634e9ad. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5342044147
|
jameskoster
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Much better, thank you! Approving as the original issue is fixed.
It would be really nice (either here or in a follow-up) to also hide the parent selector when direct descendants of Post Content are selected. It doesn't really serve any meaningful purpose in this context:
noisysocks
force-pushed
the
fix/remove-overlay-on-contentOnly-blocks
branch
from
6805719
to
69f2506
Compare
noisysocks
added
the
[Feature] Page Content Focus
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #51259.
Prevents the block overlay from appearing on blocks with an editing mode of
'contentOnly'. For example the Post Content block when the user is focused on editing page content.Why?
The block overlay is redundant on blocks with an editing mode of
'contentOnly'. There will be no block controls (toolbar items, etc.) once you select the block, so why push users towards selecting the block instead of its children?How?
Changes the logic in
__unstableHasActiveBlockOverlayActive.Testing Instructions