DocumentActions: Animate between page and template mode #51224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Enhancement
|
Size Change: +493 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ff08eb9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5174127824
|
|
Works well for me. We discussed using AnimatePresence but decided plain CSS was more lightweight for now. |
SaxonF
approved these changes
Jun 6, 2023
noisysocks
added
the
[Feature] Page Content Focus
This was referenced Jul 10, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
) * DocumentActions: Animate between page and template mode * Remove unnecessary setHasEditedTemplate() * refine toolbar animation --------- Co-authored-by: Saxon Fletcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follows #50857.
Makes the
DocumentActionscontrol (at the top of the screen) animate between page editing mode and template editing mode.Why?
How?
I just used CSS
@keyframes. Briefly consideredframerbut it would require refactoringDocumentActionsa little bit to get theexiteffect working and also it would be a new dependency in@wordpress/edit-site. KISS.Testing Instructions
Screenshots or screencast
Kapture.2023-06-05.at.16.42.33.mp4