Fix multi entities saved state in the post editor #47734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
Size Change: +208 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Feb 3, 2023
|
I actually I think that difference is related, but If I fix it here, I'll introduce a difference in site editor. So I'll have to look more to understand the difference between both editors. |
|
The failing Playwright test might be related to the changes. |
|
So the 1px difference is because the post editor header is 61px height and the site editor is 60px height so the issue is actually not in the "save panel". That said, temporarily, I can bump the header size of the save panel in the post editor. Solving the header height might be more complex right now. |
|
Flaky tests detected in 628bfb4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4085159413
|
|
Looks good. The only thing I noticed is a pixel maybe in site editor in the width now :) It's already in trunk though.
|
kevin940726
reviewed
Feb 3, 2023
|
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #47142
What?
In #47142 we updated the multi entities saved state component to be independent from the place it's rendered in (Don't assume it's a sidebar). It created some small issues in the post editor which are being fixed by this PR.
Testing Instructions
1- Open the post editor
2- Add a reusable block and edit it
3- Click the publish button
4- The publish sidebar should show up properly