Add basic edit button UI to Nav block offcanvas editor #45815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
getdave
requested review from
scruffian,
MaggieCabrera,
georgeh,
draganescu and
ajlende
4 tasks
|
Size Change: +74 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
scruffian
reviewed
Nov 16, 2022
| @@ -132,6 +133,14 @@ function ListViewBlock( { | |||
| ) | |||
| : __( 'Options' ); | |||
|
|
|||
| const editAriaLabel = blockInformation | |||
There was a problem hiding this comment.
Why not put this in the component itself?
There was a problem hiding this comment.
Seems like other labels are here as well.
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds an "Edit" icon button to the off canvas editor list view for each block node which when clicked selects the given block.
This is a stepping stone on the path towards the "drill down" panels system (see also the mockup.
Please don't worry - this is not the final product 😄
Built on foundation laid down in #45575.
Co-authored-by: George Hotelling [email protected]
Why?
We need the edit button UI in place for basic interactions.
How?
Adds add new button component and displays on hover.
Testing Instructions
Screenshots or screencast
Screen.Capture.on.2022-11-16.at.16-24-49.mp4