-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Link: Add the URL field to the Navigation Link inspector controls #45751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Enhancement
A suggestion for improvement.
[Block] Navigation Link
Affects the Navigation Link Block
labels
Nov 14, 2022
Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
4 tasks
Size Change: +16 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation Link
Affects the Navigation Link Block
Needs User Documentation
Needs new user documentation
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As outlined in #42257, the inspector controls for the Navigation Link block should contain the URL details for a link as well as the other details.
Why?
As part of #42257 we want to make it easier to edit Navigation Links off the canvas.
How?
This just adds a new URL field to the top of the inspector controls, so that users can edit the URL from the inspector controls as well as from the main link control.
Testing Instructions
Screenshots or screencast