Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Move wp_enqueue_block_view_script to experiments #44414

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Sep 23, 2022

What?

Related to #43440.

We decided against including the following function in WordPress 6.1:

function wp_enqueue_block_view_script( $block_name, $args ) {

This PR moves its definition to lib/experimental until we have a more pressing need to include it in WordPress core.

@gziolo gziolo self-assigned this Sep 23, 2022
@gziolo gziolo added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Code Quality Issues or PRs that relate to code quality labels Sep 23, 2022
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! As previously discussed on Slack, moving this makes perfect sense at this point 👍

@gziolo gziolo merged commit 4a61eb8 into trunk Sep 23, 2022
@gziolo gziolo deleted the update/move-function-to-experiments branch September 23, 2022 09:11
@github-actions github-actions bot added this to the Gutenberg 14.3 milestone Sep 23, 2022
@ramonjd ramonjd added the Needs PHP backport Needs PHP backport to Core label Jun 5, 2023
@ramonjd ramonjd removed the Needs PHP backport Needs PHP backport to Core label Jun 30, 2023
@kimmenbert
Copy link

Any plans to push this into WP Core any time soon? Or is there some alternative approach now to enqueue scripts for singular block types depending if they are in use or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants