Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves the UX of menu management in the navigation block #42987

Merged
merged 17 commits into from
Sep 5, 2022

Commits on Sep 2, 2022

  1. Configuration menu
    Copy the full SHA
    e4088ef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea13309 View commit details
    Browse the repository at this point in the history
  3. stub toolpanel item

    draganescu committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    6fa0395 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b2d8746 View commit details
    Browse the repository at this point in the history
  5. fixes label update bug

    draganescu committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    4005be1 View commit details
    Browse the repository at this point in the history
  6. labels navigation menu selector if no menus or deleted menu, fixes la…

    …bel when importing classic menu
    draganescu committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    69ed1eb View commit details
    Browse the repository at this point in the history
  7. adds the chevron

    draganescu committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    1fcf142 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2291f6c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    54dd7c0 View commit details
    Browse the repository at this point in the history
  10. Implements handling focus persistence in the Navigation Selector acco…

    …rding to #42956
    
    Switching between menus keeps the menu open and focused on the current selection.
    Importing classic menus or creating new ones focuses the current navigation block.
    
    Co-authored-by: Daniel Richards <[email protected]>
    draganescu and talldan committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    26f90bf View commit details
    Browse the repository at this point in the history
  11. It looks like hasManagePermissions is not cached between API calls …

    …so we refresh this quite often when switching between menus. For a more consistent UI experience we disabe the menu management link untill `hasManagePermissions` is refreshed.
    
    Another option would be to cache this at a component level. But, this could be more accurate?
    draganescu committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    6202bad View commit details
    Browse the repository at this point in the history
  12. Closes the dropdown when importing or creating new menu as in #43529

    Fixes slow connection UX by disabling and enabling the selector and the manage menus link depending on data status.
    
    Co-authored-by: Dave Smith <[email protected]>
    draganescu and getdave committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    d641309 View commit details
    Browse the repository at this point in the history
  13. Larger commit, adds:

    - The label of the currently selected menu updates if menu is renamed from advanced
    - Uses a visually hidden label to explain this is a menu switcher
    - Defaults to a button if there are no block menus and no classic menus
    - Renames "Loading options ..." to "Loading ..."
    
    Co-authored-by: Javier Arce <[email protected]>
    Co-authored-by: Alex Stine <[email protected]>
    3 people committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    52f96ca View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. Configuration menu
    Copy the full SHA
    79322f0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3db76f3 View commit details
    Browse the repository at this point in the history
  3. alphabetize CSS properties

    scruffian committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    4433460 View commit details
    Browse the repository at this point in the history
  4. Incorporates review feedback:

    - replaces disabled with isBusy for toggle working state
    - refactores some conditionals for better readability
    - adds consistency to the toggle label
    
    Co-authored-by: Daniel Richards <[email protected]>
    Co-authored-by: Dave Smith <[email protected]>
    Co-authored-by: Javier Arce <[email protected]>
    Co-authored-by: Paal Joachim Romdahl <[email protected]>
    5 people committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    c194abd View commit details
    Browse the repository at this point in the history