-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves the UX of menu management in the navigation block #42987
Commits on Sep 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e4088ef - Browse repository at this point
Copy the full SHA e4088efView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea13309 - Browse repository at this point
Copy the full SHA ea13309View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fa0395 - Browse repository at this point
Copy the full SHA 6fa0395View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2d8746 - Browse repository at this point
Copy the full SHA b2d8746View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4005be1 - Browse repository at this point
Copy the full SHA 4005be1View commit details -
labels navigation menu selector if no menus or deleted menu, fixes la…
…bel when importing classic menu
Configuration menu - View commit details
-
Copy full SHA for 69ed1eb - Browse repository at this point
Copy the full SHA 69ed1ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fcf142 - Browse repository at this point
Copy the full SHA 1fcf142View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2291f6c - Browse repository at this point
Copy the full SHA 2291f6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54dd7c0 - Browse repository at this point
Copy the full SHA 54dd7c0View commit details -
Implements handling focus persistence in the Navigation Selector acco…
…rding to #42956 Switching between menus keeps the menu open and focused on the current selection. Importing classic menus or creating new ones focuses the current navigation block. Co-authored-by: Daniel Richards <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 26f90bf - Browse repository at this point
Copy the full SHA 26f90bfView commit details -
It looks like
hasManagePermissions
is not cached between API calls ……so we refresh this quite often when switching between menus. For a more consistent UI experience we disabe the menu management link untill `hasManagePermissions` is refreshed. Another option would be to cache this at a component level. But, this could be more accurate?
Configuration menu - View commit details
-
Copy full SHA for 6202bad - Browse repository at this point
Copy the full SHA 6202badView commit details -
Closes the dropdown when importing or creating new menu as in #43529
Fixes slow connection UX by disabling and enabling the selector and the manage menus link depending on data status. Co-authored-by: Dave Smith <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d641309 - Browse repository at this point
Copy the full SHA d641309View commit details -
- The label of the currently selected menu updates if menu is renamed from advanced - Uses a visually hidden label to explain this is a menu switcher - Defaults to a button if there are no block menus and no classic menus - Renames "Loading options ..." to "Loading ..." Co-authored-by: Javier Arce <[email protected]> Co-authored-by: Alex Stine <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 52f96ca - Browse repository at this point
Copy the full SHA 52f96caView commit details
Commits on Sep 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 79322f0 - Browse repository at this point
Copy the full SHA 79322f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3db76f3 - Browse repository at this point
Copy the full SHA 3db76f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4433460 - Browse repository at this point
Copy the full SHA 4433460View commit details -
- replaces disabled with isBusy for toggle working state - refactores some conditionals for better readability - adds consistency to the toggle label Co-authored-by: Daniel Richards <[email protected]> Co-authored-by: Dave Smith <[email protected]> Co-authored-by: Javier Arce <[email protected]> Co-authored-by: Paal Joachim Romdahl <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c194abd - Browse repository at this point
Copy the full SHA c194abdView commit details