Site Editor: Add New - Custom/General template #42127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
|
This is looking good and working well. My one small piece of feedback is that the the description appearing both on the menuitem, and in the modal feels a bit repetitive. I think we can remove it from the modal like so:
I acknowledge that some context will be lost in the post editor, but now that we can create templates for single entities we need to revisit that UX anyway (#41257). |
jorgefilipecosta
requested review from
ntsekouras and
mcsf
and removed request for
ntsekouras
ntsekouras
reviewed
Jul 6, 2022
| @@ -253,6 +259,19 @@ export default function NewTemplate( { postType } ) { | |||
| ); | |||
| } ) } | |||
| </MenuGroup> | |||
| <MenuItem | |||
There was a problem hiding this comment.
Should we append this to the existing MenuGroup? Should we add in a separate one? 🤔 Right now there is more space from the other items due to that..
There was a problem hiding this comment.
Nice catch I missed wrapping the item in a group. We want a new group so we have a divider.
ntsekouras
reviewed
Jul 6, 2022
|
|
||
| setIsBusy( true ); | ||
|
|
||
| await createTemplate( |
There was a problem hiding this comment.
I don't think we need to await and close the modal here, as the passed createTemplate will navigate to a different page after creation and unmount this component.
jorgefilipecosta
force-pushed
the
add/custom-generic-template-option-to-site-editor-templates
branch
from
3faa4df to
35451ea
Compare
jorgefilipecosta
force-pushed
the
add/custom-generic-template-option-to-site-editor-templates
branch
from
35451ea to
1a89e8e
Compare
jorgefilipecosta
commented
Jul 8, 2022
There was a problem hiding this comment.
Hi @ntsekouras, @jameskoster thank you for the reviews. Your feedback was applied!
|
Size Change: +367 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
Thanks for the design tweak @jorgefilipecosta.
It's somewhat tangential and doesn't need to hold up this PR but I'd love to hear thoughts from @WordPress/gutenberg-design and/or the copy review team on the input helper text:
On reflection I'm not sure that "purpose" is the correct wording, and whether there might be a better example than "full width". Perhaps it should just be:
Describe the template, e.g. "Post with sidebar"
jorgefilipecosta
deleted the
add/custom-generic-template-option-to-site-editor-templates
branch
|
Hi @jameskoster, I like |
|
@jorgefilipecosta sounds good, let's open a PR and get the wording right therein :) |
38 tasks
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to create a generic template on the site editor. The generic template can be used on any post or page.
Closes: #36860
Part of: #37407
No UI is created, we are using the same modal that already exists on the edit post.
cc: @jameskoster in case you have any design insights.
The template is created in a blank content state for now like what happens for all the other templates.