Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submenu: Add revert button. #38203

Merged
merged 21 commits into from
Feb 11, 2022
Merged

Submenu: Add revert button. #38203

merged 21 commits into from
Feb 11, 2022

Commits on Feb 8, 2022

  1. Add revert button

    @getdave
    getdave committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    d55b560 View commit details
    Browse the repository at this point in the history

  2. Adjust button wording

    @getdave
    getdave committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    8e3c5e4 View commit details
    Browse the repository at this point in the history

  3. Only show convert button when no children present

    @getdave
    getdave committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    8bafb6e View commit details
    Browse the repository at this point in the history

  4. Move to separate menu group

    @getdave
    getdave committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    eb77dfc View commit details
    Browse the repository at this point in the history

  5. USe undo icon

    @getdave
    getdave committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    de6c3d8 View commit details
    Browse the repository at this point in the history

  6. Add new removeSubmenu icon

    @getdave
    getdave committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    6b84577 View commit details
    Browse the repository at this point in the history

  7. Apply icon to revert button

    @getdave
    getdave committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    975b401 View commit details
    Browse the repository at this point in the history

  8. Show revert button for single empty link block

    @getdave
    getdave committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    313fd72 View commit details
    Browse the repository at this point in the history

  9. Add test for reverting empty submenu

    @getdave
    getdave committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    64e3245 View commit details
    Browse the repository at this point in the history

  10. Extract waitForBlock helper function

    @getdave
    getdave committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    b637f03 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. Add test for when convert button should not show

    @getdave
    getdave committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    cb6298d View commit details
    Browse the repository at this point in the history

  2. Refactor block toolbar selections to use helper

    @getdave
    getdave committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    89a3ad1 View commit details
    Browse the repository at this point in the history

  3. Add test to cover single unpopulated link item in submenu

    @getdave
    getdave committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    ee68124 View commit details
    Browse the repository at this point in the history

  4. Increase specificity of block toolbar selector

    @getdave
    getdave committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    9c20a03 View commit details
    Browse the repository at this point in the history

  5. Revert extension of populateWithOneItem helper 

    This is no longer required
    @getdave
    getdave committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    6704fd8 View commit details
    Browse the repository at this point in the history

  6. Remove debugging

    @getdave
    getdave committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    1fe5b13 View commit details
    Browse the repository at this point in the history

  7. Make use of existing e2e test helper

    @getdave
    getdave committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    ae764ba View commit details
    Browse the repository at this point in the history

  8. Correct spelling in comment

    @getdave
    getdave committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    c141258 View commit details
    Browse the repository at this point in the history

  9. Move check for "empty link block" to be based on label

    @getdave
    getdave committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    7bca795 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Disable convert button instead of removing

    @getdave
    getdave committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    a8db073 View commit details
    Browse the repository at this point in the history

  2. Fix SVG DOM error by using camelCase prop names

    @getdave
    getdave committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    2b2046c View commit details
    Browse the repository at this point in the history