Navigation Menu: Show submenus only on select in the editor. #29869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Block] Navigation
|
Size Change: +48 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
I have some worries about dictating the behavior of submenus while in the editor. With this PR we no long default to showing submenu's on hover in the editor, no matter the reality of how submenus actually work on the site's frontend. My expectation is that while editing the navigation block it should look and work just like it would on my actual site. And, I expect that at some point the navigation block will allow me to adjust the interactions myself. That is, I expect some day to have a setting like:
When that day comes there would be confusion if the editor overrides the interaction. Perhaps I'm worrying to much, too soon. But these are the things that keep me awake at night. -- I believe the discussion in #25012 is that the submenu should still appear when it's parent is hovered — but only if the Navigation block (or one of it's children) is selected. I still believe this to be the best option. -- I noticed that turning off the "show submenu indicators" now leads to a situation where it's impossible to notice what menu's have submenus without first clicking; Previous to this PR you could hover the item to see if it had a submenu. |
jasmussen
force-pushed
the
try/navigation-hover-on-selected
branch
from
97ffca2 to
015ab39
Compare
Alright, I think I have that now:
The CSS is a little more gnarly, but I've added a comment. I think this is ready to move on from draft state. |
jasmussen
requested review from
adamziel,
ajitbohra,
kevin940726,
noisysocks and
tellthemachines
as code owners
37 tasks
jasmussen
force-pushed
the
try/navigation-hover-on-selected
branch
from
89e9e89 to
522806d
Compare
draganescu
approved these changes
Mar 18, 2021
This was referenced Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does two things.
For the 2nd item, I'm not entirely sure I understood correctly the intended behavior here, so I have marked this PR as draft until I can get a sanity check that I didn't misunderstand something.
GIFs:
Please, notably on the 2nd gif showing expanding of submenu items on the navigation screen, let me know whether this is the correct behavior, as it seems right to me.
How has this been tested?
Please test a navigation block with submenus. Submenus should only show up when you click the parent item first. Frontend should be the same, and show them on hover or focus.
Please test the navigation screen and verify that submenus behave as they should.
Checklist: