Rename the "Preview" button label to "View" #29151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -5 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
An issue for extending preview menu is related: #25309 |
6 tasks
|
Long overdue. Ship it! |
|
I think it is a good idea to change from "Preview" to "View". We need to get some perspectives on this. |
|
Well, it makes a ton of sense for a site editor which already is a preview. I do in the future see the post editor converging with the site editor, to the point that while a separate site editor item might still exist, you will commonly enter the site editor from the post editor. In light of that, it bear thinking: does it make sense to rename the same element from Preview to View in the post editor? In absence of the two being the same, it would have to switch when shifting context. |
|
To me, Preview designates that the changes are not published yet, and is showing front end instead of back end. View sounds more like the only difference is front end versus back end. |
|
To Joen's point, everything you do in the editor is effectively both a preview and an edit, until published (assuming good editor styles). Hence switching from desktop to tablet is simply an exercise in changing the perspective of the current edit/preview session. "Preview" feels too prescriptive to me, and is more problematic when you consider that historically "preview" links in WordPress have sent you to the frontend, which isn't what happens here. To carry on that train of thought, a live preview is definitely something we need. "Browse mode" has been suggested in the past (#23328), and more recently a basic "Preview site" feature was discussed briefly in #29398. I would suggest that both live preview and edit modes should offer users an affordance to switch the view between desktop, tablet, and mobile orientations. Having a "Preview" menu within a "Live preview" feature seems a little nebulous to me. |
|
-100 In my opinion "View" should be reserved for displaying the content in the front end. |
|
Would showing an icon (maybe with a label) work? An example from Wix:
Google Sites:
Although I'm a big fan of text-based UI, I bet these icons would be more clear than many of the other icons in the header currently. 😅 Any custom modes could show up as text or with their own custom icon. |
|
As I touched on in the OP, the view/preview menu could potentially house many options beyond device simulations, so I'm not sure the icon would be a scalable solution. |
|
@jameskoster I think the key is having each mode add icon in addition to label but still show only active mode as icon in the header:
That way user learns what each icon means by just opening the dropdown. Though I agree it's unclear how the ideas you listed would fit that format even as icons. In all those cases you suggest having "toggles" rather than the whole menu function as "select" input which has just one active selection, if I understood right? In that case the whole dropdown concept might not work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several recent discussions the idea of placing access to new features in the "Preview" menu has arisen:
In each of these situations – plus the existing toggles for mobile, tablet, and desktop – "Preview" is perhaps not the most appropriate label. Historically, "Preview" in WordPress editor terms would open a non-editable, live version of the current document. But after taking any of these actions in the editor, one retains full edit-ability of all elements on the canvas. It is less a preview and more of a simple view option. Hence this PR to see how switching "Preview" to "View" feels.