Disable alignment for innerBlocks of Nav Block #27365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Block] Navigation
talldan
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
Thanks @jordesign, this is working well for me, it would be great to get it merged.
I notice the branch has conflicts, they look easy to resolve, should just be able to accept both sets of changes.
trying to fix conflict
|
Hey @talldan I think that conflict is resolved now (first time doing so - so I hope it worked) |
talldan
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the Experimental Layout property to disable alignment settings for InnerBlocks of the Navigation Block.
Done in the same method as outlined for the Buttons block here:
#26380
This addresses issue #27179 - where setting an alignment on the Social Links block breaks the display of the Navigation Block.