Social Icons: Add missing padding support, update margin support (#43885

)
WordPress · Sep 7, 2022 · ccc0d51 · ccc0d51
1 parent ac872b8
commit ccc0d51
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/docs/reference-guides/core-blocks.md b/docs/reference-guides/core-blocks.md
@@ -761,7 +761,7 @@ Display icons linking to your social media profiles or sites. ([Source](https://
 
 -	**Name:** core/social-links
 -	**Category:** widgets
--	**Supports:** align (center, left, right), anchor, color (background, gradients, ~~enableContrastChecker~~, ~~text~~), spacing (blockGap, margin, units)
+-	**Supports:** align (center, left, right), anchor, color (background, gradients, ~~enableContrastChecker~~, ~~text~~), spacing (blockGap, margin, padding, units)
 -	**Attributes:** customIconBackgroundColor, customIconColor, iconBackgroundColor, iconBackgroundColorValue, iconColor, iconColorValue, openInNewTab, showLabels, size
 
 ## Spacer

diff --git a/packages/block-library/src/social-links/block.json b/packages/block-library/src/social-links/block.json
@@ -67,7 +67,8 @@
 		},
 		"spacing": {
 			"blockGap": [ "horizontal", "vertical" ],
-			"margin": [ "top", "bottom" ],
+			"margin": true,
+			"padding": true,
 			"units": [ "px", "em", "rem", "vh", "vw" ],
 			"__experimentalDefaultControls": {
 				"blockGap": true

diff --git a/packages/block-library/src/social-links/style.scss b/packages/block-library/src/social-links/style.scss
@@ -1,4 +1,7 @@
 .wp-block-social-links {
+	// This block has customizable padding, border-box makes that more predictable.
+	box-sizing: border-box;
+
 	padding-left: 0;
 	padding-right: 0;
 	// Some themes set text-indent on all <ul>