Only add the required classnames if there's a valid style value or cl…

…assname slug.
WordPress · Apr 14, 2022 · 6f35126 · 6f35126
1 parent e6586ef
commit 6f35126
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 12 deletions.
diff --git a/packages/style-engine/class-wp-style-engine.php b/packages/style-engine/class-wp-style-engine.php
@@ -144,31 +144,29 @@ protected static function get_classnames( $style, $style_definition ) {
 			return $classnames;
 		}
 
-		// Remove falsy values.
-		$filtered_style = array_filter(
-			$style,
-			function( $value ) {
-				return ! empty( $value );
-			}
-		);
+		$required_classnames = array();
 
 		if ( ! empty( $style_definition['classnames'] ) ) {
 			foreach ( $style_definition['classnames'] as $classname => $property ) {
-				// Only add the required classname if there's a valid style value or classname slug.
-				if ( true === $property && ! empty( $filtered_style ) ) {
-					$classnames[] = $classname;
+				if ( true === $property ) {
+					$required_classnames[] = $classname;
 				}
 
-				if ( isset( $filtered_style[ $property ] ) ) {
+				if ( isset( $style[ $property ] ) ) {
 					// Right now we expect a classname pattern to be stored in BLOCK_STYLE_DEFINITIONS_METADATA.
 					// One day, if there are no stored schemata, we could allow custom patterns or
 					// generate classnames based on other properties
 					// such as a path or a value or a prefix passed in options.
-					$classnames[] = sprintf( $classname, _wp_to_kebab_case( $filtered_style[ $property ] ) );
+					$classnames[] = sprintf( $classname, _wp_to_kebab_case( $style[ $property ] ) );
 				}
 			}
 		}
 
+		// Only add the required classnames if there's a valid style value or classname slug.
+		if ( ! empty( $required_classnames ) && ( $style['value'] || ! empty( $classnames ) ) ) {
+			$classnames = array_merge( $required_classnames, $classnames );
+		}
+
 		return $classnames;
 	}
 

diff --git a/packages/style-engine/phpunit/class-wp-style-engine-test.php b/packages/style-engine/phpunit/class-wp-style-engine-test.php
@@ -176,6 +176,20 @@ public function data_generate_styles_fixtures() {
 					'classnames' => 'has-text-color',
 				),
 			),
+			'invalid_classnames_slug_key'                  => array(
+				'block_styles'    => array(
+					'color' => array(
+						'text'       => array(
+							'cheese' => 'pizza',
+						),
+						'background' => array(
+							'tomato' => 'sauce',
+						),
+					),
+				),
+				'options'         => array(),
+				'expected_output' => array(),
+			),
 			'invalid_classnames_options'                   => array(
 				'block_styles'    => array(
 					'typography' => array(