Skip to content

Commit

Permalink
Fix the heading hierarchy in the site editor (#51696)
Browse files Browse the repository at this point in the history
  • Loading branch information
@youknowriad
youknowriad authored Jun 21, 2023
1 parent 15af7b7 commit 3b5975b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-navigation-screen-details-panel/index.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function SidebarNavigationScreenDetailsPanel( { title, children, spacing } ) {
{ title && (
<Heading
className="edit-site-sidebar-navigation-details-screen-panel__heading"
level={ 3 }
level={ 2 }
>
{ title }
</Heading>
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-navigation-screen/index.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export default function SidebarNavigationScreen( {
<Heading
className="edit-site-sidebar-navigation-screen__title"
color={ 'white' }
level={ 2 }
level={ 1 }
size={ 20 }
>
{ ! isPreviewingTheme()
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/specs/site-editor/command-center.spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ test.describe( 'Site editor command center', () => {
.click();
await page.keyboard.type( 'index' );
await page.getByRole( 'option', { name: 'index' } ).click();
await expect( page.getByRole( 'heading', { level: 2 } ) ).toHaveText(
await expect( page.getByRole( 'heading', { level: 1 } ) ).toHaveText(
'Index'
);
} );
Expand Down

1 comment on commit 3b5975b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky tests detected in 3b5975b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5333472323
📝 Reported issues:

Please sign in to comment.