Skip to content

Commit

Permalink
DropdownMenu: Increase option height to 40px (#67435)
Browse files Browse the repository at this point in the history
* DropdownMenu: Increase option height to 40px

* Add changelog

Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>
  • Loading branch information
3 people authored Dec 2, 2024
1 parent d8a457b commit 232d14f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 1 deletion.
3 changes: 3 additions & 0 deletions packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
### Enhancements

- `BorderBoxControl`: Reduce gap value when unlinked ([#67049](https://github.com/WordPress/gutenberg/pull/67049)).
- `DropdownMenu`: Increase option height to 40px ([#67435](https://github.com/WordPress/gutenberg/pull/67435)).
- `MenuItem`: Increase height to 40px ([#67435](https://github.com/WordPress/gutenberg/pull/67435)).
- `MenuItemsChoice`: Increase option height to 40px ([#67435](https://github.com/WordPress/gutenberg/pull/67435)).

### Experimental

Expand Down
1 change: 1 addition & 0 deletions packages/components/src/dropdown-menu/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ function UnconnectedDropdownMenu( dropdownMenuProps: DropdownMenuProps ) {
{ controlSets?.flatMap( ( controlSet, indexOfSet ) =>
controlSet.map( ( control, indexOfControl ) => (
<Button
__next40pxDefaultSize
key={ [
indexOfSet,
indexOfControl,
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/dropdown-menu/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@

.components-menu-item__button,
.components-menu-item__button.components-button {
min-height: $button-size;
min-height: $button-size-next-default-40px;
height: auto;
text-align: left;
padding-left: $grid-unit-10;
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/menu-items-choice/style.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.components-menu-items-choice,
.components-menu-items-choice.components-button {
min-height: $button-size-next-default-40px;
height: auto;

svg {
Expand Down

0 comments on commit 232d14f

Please sign in to comment.