Theme preview workflow: use external github action #232
+13
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikachan did we implement this on the a8c themes? I can't remember if it had security issues |
|
Yes, I think using the external copy worked around the security issues and we were able to use |
|
Awesome, I'll review this asap then. And it would be great to bring the theme check action too to this repo |
|
Keep in mind that the action has been moved to https://github.com/WordPress/action-wp-playground-pr-preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes using an external copy of the preview themes workflow, which will allow us to run it on
pull_request_targetsafely, since the code for the workflow itself lives outside of the repo — this means that the workflow will be able to comment on PRs created by non-members of the WordPress GitHub org.The code is currently under my GitHub account, but I'll be moving to change ownership to the WordPress org eventually.