Fix panic with wooting_analog_get_connected_devices_info #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to have been an instance where swap_with_slice panicked because `c_devices.len()` was `0` for some reason. I'm no Rust expert, but this logic seems to be working to correctly map devices into c_devices.
|
I'm a little confused, as the before and after code should functionally behave very similarly. In what scenario were you able to trigger the panic? Like is it very reproducible where you can say definitively that this change prevents it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to have been an instance where swap_with_slice panicked because
c_devices.len()was0for some reason when using the example C plugin.I'm no Rust expert, but this logic seems to be working to correctly map
devicesintoc_devices. Tested with various plugins.