Do not pass null to the $text parameter of adapter's notify()

The `$text` parameter is documented to take a `string`, not a `?string` and in fact the Console adapter unconditionally calls a variant of `substr()` on the given `$text` to shorten it to the configured display width. With PHP 8.1 this fails, because native functions no longer accept `null` for a string parameter: > TypeError: grapheme_substr(): Argument #1 ($string) must be of type string, null given in […] Signed-off-by: Tim Düsterhus <[email protected]>
WoltLab · Jul 28, 2022 · c6adc87 · c6adc87
1 parent 6b97d7d
commit c6adc87
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/ProgressBar.php b/src/ProgressBar.php
@@ -42,7 +42,7 @@ class ProgressBar
  *
  * @var string
  */
- protected $statusText = null;
+ protected $statusText = '';
 
  /**
  * Adapter for the output

diff --git a/test/ProgressBarTest.php b/test/ProgressBarTest.php
@@ -80,6 +80,13 @@ public function testEtaZeroPercent()
  $this->assertEquals(null, $progressBar->getTimeRemaining());
  }
 
+ public function testMissingTextIsNotNull()
+ {
+ $progressBar = $this->_getProgressBar(0, 100);
+
+ $this->assertSame('', $progressBar->getText());
+ }
+
  // @codingStandardsIgnoreStart
  protected function _getProgressBar($min, $max, $persistenceNamespace = null)
  {