Comment backend overhaul #5944
Merged
Comment backend overhaul #5944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtdesign
requested changes
Jun 14, 2024
There was a problem hiding this comment.
After finishing the review I question some of my remarks. In particular commands should be designed to be only called with clean data, otherwise following the “garbage in, garbage out” principle. They shouldn’t perform any validation whatsoever because this is the callee’s job.
Therefore please disregard my comments that suggest additional validations for commands and strip the existing validation unless you feel it is really important because it would otherwise cause serious issues.
Also, some of my comments are merely remarks so please feel free to disregard my comments at your discretion.
wcfsetup/install/files/lib/system/comment/command/CreateComment.class.php
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/comment/command/CreateComment.class.php
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/comment/command/DeleteComments.class.php
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/comment/response/command/CreateResponse.class.php
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/comment/response/command/CreateResponse.class.php
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/endpoint/controller/core/comments/EnableComment.class.php
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/endpoint/controller/core/comments/RenderComment.class.php
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/endpoint/controller/core/comments/UpdateComment.class.php
Outdated
Show resolved
Hide resolved
...nstall/files/lib/system/endpoint/controller/core/comments/responses/EnableResponse.class.php
Outdated
Show resolved
Hide resolved
...nstall/files/lib/system/endpoint/controller/core/comments/responses/RenderResponse.class.php
Outdated
Show resolved
Hide resolved
This was referenced Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the backend of the comment system to RPC controllers and commands and is intended to serve as a template for the future modernization of other backends.