Handling IllegalStateException in case of mutiple Buy method call

[Florian-masse]

Possible fix for #54

[CyrilleGuimezanes]

Looks good 👍

[jrouault]

Hello,
Thank you for the fix! And sorry for the late answer.
A few possible improvements:

• Ideally, not modifying the IabHelper.java would be preferable. It's considered as an "external" dependency. If we were to update it we would lose your changes, or have to apply them once again.
  A quick search pointed me to an updated version of this file there:
  https://github.com/googlesamples/android-play-billing/blob/master/TrivialDrive/app/src/main/java/com/example/android/trivialdrivesample/util/IabHelper.java
  Arguably, it hasn't been updated since a few years.
• This seems to fix only the case of detecting a purchase started while another async operation is already happening. The exception happens for 3 async operations: consume, launchPurchaseFlow and refresh inventory.
  So for example, this fix would work if a "launchPurchaseFlow" was started while another "launchPurchaseFlow" is happening, which was the initial scenario in the issue.
  However, if a "consume" operation is started while another async operation is happening, the IllegalStateException exception would still be thrown.
• Another error code than INVALID_TRANSACTION_STATE might be more appropriate. Something more general related to the fact that some async operation can not be run in parallel. However this would require changes to the Javascript-side as well.

[Florian-masse]

Hello,
Thank you for the answer.

About those improvements:

• I should have seen where IabHelper.java came from. It would be a whole new issue to use the updated class from your link but that only makes your point an even better one.
• This just makes sense, two async calls to go.
• Error codes are shared between the three parts of the plugin (Javascript, Java and Objective-C). Should not be a problem anyway.

Because the implementation would change otherwise , do you confirm the need of your first point over the second one ?

[jrouault]

Just to make sure we are on the same page on the first point: I am not asking to update the file but simply not to modify it.
So yes, the first point has priority. But it should be possible to fix it in a way that makes the second point as easy to fix.

[jrouault]

Sorry for the late review, and thanks for the changes!
It looks good. There's just a very small typo in the readme 😃

[jrouault]

Very small typo here, it should be 26 :)

[Florian-masse]

Here you go :)

[Florian-masse]

Sorry, as my account is quite recent, github flagged it which hid everything I did on the platform.

[jrouault]

No worries 😃 Thanks for fixing the last typo, I'll merge the PR asap!