Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method Buy - IllegalStateException #54

Open
CyrilleGuimezanes opened this issue Apr 10, 2018 · 5 comments
Open

Method Buy - IllegalStateException #54

CyrilleGuimezanes opened this issue Apr 10, 2018 · 5 comments

Comments

@CyrilleGuimezanes
Copy link
Contributor

CyrilleGuimezanes commented Apr 10, 2018

Hello,

On Google Play Console I have crash report with this stack trace:

image

I'm not able to reproduce: When I buy an object everything works well but it's a test purchase.

Do you know if I miss something? This seem to concern every device (3 exemples since I use 2.2.0 )

@CyrilleGuimezanes
Copy link
Contributor Author

Oh, this seem to be a common problem: http://support.gamedonia.com/discussions/problems/125-android-application-crashing-when-purchasing

=> I will disable all action on the button after the click. this error occurs when the purchase flow is call two times

@jrouault
Copy link
Member

Hello! Thanks for your feedback and finding out the source of the issue.

That's probably something we could prevent directly in the plugin. What do you think about it?

@CyrilleGuimezanes
Copy link
Contributor Author

Hello!
In the plugin itself, you maybe can catch the IllegalStateException and return a specific error code (like "operation already in progress".
But I don't think that disable methods during process is a good idea. It's the game develpper responsability.

I personaly disabled the "buy" button after the first click and until I have a success or error callback and I did not have error report anymore since few days.

@Florian-masse
Copy link

Hi,
Is that what you had in mind ?

@CyrilleGuimezanes
Copy link
Contributor Author

Absolutely 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants